-
Notifications
You must be signed in to change notification settings - Fork 874
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: elastic/eui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v37.6.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: elastic/eui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v37.6.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 455 files changed
- 4 contributors
Commits on Sep 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8241bcf - Browse repository at this point
Copy the full SHA 8241bcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a3fdc8 - Browse repository at this point
Copy the full SHA 0a3fdc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a0ab2f - Browse repository at this point
Copy the full SHA 1a0ab2fView commit details
Commits on Sep 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for dc7b70d - Browse repository at this point
Copy the full SHA dc7b70dView commit details -
[euiScreenReaderOnly] Use
clipto fix scrolling issues caused by ab……solute positioning (#5130) * Update .euiScreenReaderOnly to use clip - this prevents issues with absolute positioning and scrolling containers, and works on all modern browsers supported by EUI * Add changelog entry * [PR feedback] Add comment with more context
Constance authoredSep 2, 2021 Configuration menu - View commit details
-
Copy full SHA for bca85fb - Browse repository at this point
Copy the full SHA bca85fbView commit details -
[EuiDataGrid] Remove cell actions onmouseleave (#5120)
* Remove datagrid cell actions onmouseleave * changelog
Configuration menu - View commit details
-
Copy full SHA for 96d3b50 - Browse repository at this point
Copy the full SHA 96d3b50View commit details -
[EuiDataGrid] Add unit tests for body/ components + minor refactors (#…
…5125) * Write tests for data_grid_footer_row * Write tests for data_grid_cell_buttons * Write tests for data_grid_cell_popover * Write tests for data_grid_cell - Uses a non-inline snapshot, since this is a fairly complex component - NOTE: this is only ~80% coverage, as a lot of the class fns are extremely native DOM specific (focus, etc.) and is better tested in Cypress than Jest * Write tests for data_grid_body - They're not great, but there's a lot going on here that probably needs to be split up for more comprehensive unit-focused tests * [Suggested refactor] Clarify inMemoryValue obj types - `key` was a little nebulous and I was struggling to figure out what the data structure shoudl look like - I think tweaking the type def naming would help clarify * [Suggested refactor] DRY out repeated hasResizeObserver - It's used in two separate places with essentially the same definition - the `as any` cast doesn't seem to be needed anymore - I'm not seeing typescript errors * [Suggested refactor] DRY out misc popover content utils - DefaultColumnFormatter is repeated in DataGridBody and DataGridFooterRow - Moving the fns to their own util file lets us write unit tests for them instead of having to dive into props and also removes extra complexity from the already-long DataGridBody file * [Suggested refactor] Move defaultComparator to data_grid_schema - since comparators are schema related, and data_grid_schema contains several other similar utility exports/fns - goal is to continue making data_grid_body more encapsulated/focused on (e.g.) display logic and letting other components handle the detailed sort logic + unit tests will be written later for data_grid_schema * Update to account for latest DataGridCell mouseLeave change + small comment fix
Constance authoredSep 2, 2021 Configuration menu - View commit details
-
Copy full SHA for afaaedb - Browse repository at this point
Copy the full SHA afaaedbView commit details
Commits on Sep 3, 2021
-
[EuiDataGrid] resolve performance issues when interacting with a larg…
…e grid (#5136) * first approach, much better responsivness * refactor datagrid cell mutation observer to be much more specific at what it is watching * re-refactoring * --amend * finish re-re-refactoring * Remove console.log, target a custom attribute instead of classname * function comment * Update src/components/datagrid/body/data_grid_body.tsx Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update src/components/datagrid/body/data_grid_body.tsx Co-authored-by: Constance <constancecchen@users.noreply.github.com> * changelog * snapshots * 'revert' change to datagrid.js example Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bfa1e19 - Browse repository at this point
Copy the full SHA bfa1e19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63643c2 - Browse repository at this point
Copy the full SHA 63643c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58a5da1 - Browse repository at this point
Copy the full SHA 58a5da1View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v37.6.0...v37.6.1