Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elastic/eui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v37.6.0
Choose a base ref
...
head repository: elastic/eui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v37.6.1
Choose a head ref
  • 10 commits
  • 455 files changed
  • 4 contributors

Commits on Sep 1, 2021

  1. Updated documentation.

    chandlerprall committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    8241bcf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a3fdc8 View commit details
    Browse the repository at this point in the history
  3. Revert "revert me" (#5123)

    This reverts commit 2fbc966.
    thompsongl authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    1a0ab2f View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Fix formatting

    thompsongl authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    dc7b70d View commit details
    Browse the repository at this point in the history
  2. [euiScreenReaderOnly] Use clip to fix scrolling issues caused by ab…

    …solute positioning (#5130)
    
    * Update .euiScreenReaderOnly to use clip
    
    - this prevents issues with absolute positioning and scrolling containers, and works on all modern browsers supported by EUI
    
    * Add changelog entry
    
    * [PR feedback] Add comment with more context
    Constance authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    bca85fb View commit details
    Browse the repository at this point in the history
  3. [EuiDataGrid] Remove cell actions onmouseleave (#5120)

    * Remove datagrid cell actions onmouseleave
    
    * changelog
    chandlerprall authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    96d3b50 View commit details
    Browse the repository at this point in the history
  4. [EuiDataGrid] Add unit tests for body/ components + minor refactors (#…

    …5125)
    
    * Write tests for data_grid_footer_row
    
    * Write tests for data_grid_cell_buttons
    
    * Write tests for data_grid_cell_popover
    
    * Write tests for data_grid_cell
    
    - Uses a non-inline snapshot, since this is a fairly complex component
    
    - NOTE: this is only ~80% coverage, as a lot of the class fns are extremely native DOM specific (focus, etc.) and is better tested in Cypress than Jest
    
    * Write tests for data_grid_body
    
    - They're not great, but there's a lot going on here that probably needs to be split up for more comprehensive unit-focused tests
    
    * [Suggested refactor] Clarify inMemoryValue obj types
    
    - `key` was a little nebulous and I was struggling to figure out what the data structure shoudl look like - I think tweaking the type def naming would help clarify
    
    * [Suggested refactor] DRY out repeated hasResizeObserver
    
    - It's used in two separate places with essentially the same definition
    - the `as any` cast doesn't seem to be needed anymore - I'm not seeing typescript errors
    
    * [Suggested refactor] DRY out misc popover content utils
    
    - DefaultColumnFormatter is repeated in DataGridBody and DataGridFooterRow
    
    - Moving the fns to their own util file lets us write unit tests for them instead of having to dive into props and also removes extra complexity from the already-long DataGridBody file
    
    * [Suggested refactor] Move defaultComparator to data_grid_schema
    
    - since comparators are schema related, and data_grid_schema contains several other similar utility exports/fns
    
    - goal is to continue making data_grid_body more encapsulated/focused on (e.g.) display logic and letting other components handle the detailed sort logic
    
    + unit tests will be written later for data_grid_schema
    
    * Update to account for latest DataGridCell mouseLeave change
    
    + small comment fix
    Constance authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    afaaedb View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. [EuiDataGrid] resolve performance issues when interacting with a larg…

    …e grid (#5136)
    
    * first approach, much better responsivness
    
    * refactor datagrid cell mutation observer to be much more specific at what it is watching
    
    * re-refactoring
    
    * --amend
    
    * finish re-re-refactoring
    
    * Remove console.log, target a custom attribute instead of classname
    
    * function comment
    
    * Update src/components/datagrid/body/data_grid_body.tsx
    
    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    
    * Update src/components/datagrid/body/data_grid_body.tsx
    
    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    
    * changelog
    
    * snapshots
    
    * 'revert' change to datagrid.js example
    
    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    chandlerprall and Constance authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    bfa1e19 View commit details
    Browse the repository at this point in the history
  2. update i18ntokens

    chandlerprall committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    63643c2 View commit details
    Browse the repository at this point in the history
  3. 37.6.1

    chandlerprall committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    58a5da1 View commit details
    Browse the repository at this point in the history
Loading