fix: background color dark mode issue#719
Merged
nickofthyme merged 8 commits intoelastic:masterfrom Jun 29, 2020
Merged
Conversation
- revert existing logic for no background color - fix divide-by-zero error with combineColors function - fix text text leading line on partition charts - add warning for invalid or transparent colors - add warning for alpha values less than 1
- add themes with bgColor to partition charts - add dark theme story - update all screenshots
Collaborator
Author
|
retest this please |
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 74.80% 74.53% -0.27%
==========================================
Files 265 282 +17
Lines 8541 8896 +355
Branches 1714 1763 +49
==========================================
+ Hits 6389 6631 +242
- Misses 2099 2209 +110
- Partials 53 56 +3
Continue to review full report at Codecov.
|
markov00
approved these changes
Jun 29, 2020
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally
markov00
pushed a commit
that referenced
this pull request
Jun 29, 2020
## [19.6.1](v19.6.0...v19.6.1) (2020-06-29) ### Bug Fixes * background color dark mode issue ([#719](#719)) ([40bb526](40bb526))
Collaborator
|
🎉 This PR is included in version 19.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [19.6.1](elastic/elastic-charts@v19.6.0...v19.6.1) (2020-06-29) ### Bug Fixes * background color dark mode issue ([opensearch-project#719](elastic/elastic-charts#719)) ([a3fadc0](elastic/elastic-charts@a3fadc0))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set default background color to transparent.
Currently, most charts in kibana do not handle getting the proper base theme for the chart and use the
transparentas a default. The color can be set on the corresponding theme once the theme is commonly shared across all charts in kibana.Changes
combineColorsfunction