Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
=======================================
Coverage 72.48% 72.48%
=======================================
Files 353 353
Lines 11056 11056
Branches 2420 2420
=======================================
Hits 8014 8014
Misses 3027 3027
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
markov00
commented
Feb 2, 2021
Comment on lines
+76
to
+78
| export const Heatmap: React.FunctionComponent< | ||
| Pick<HeatmapSpec, 'id' | 'data'> & Partial<Omit<HeatmapSpec, 'chartType' | 'specType' | 'id' | 'data'>> | ||
| > = getConnect()( |
Collaborator
Author
There was a problem hiding this comment.
Here I've tried to remove the type alias to avoid exporting an alias type.
We should do the same for all the other Components
nickofthyme
approved these changes
Feb 2, 2021
| */ | ||
|
|
||
| export { Heatmap, HeatmapSpec } from './heatmap'; | ||
| export * from './heatmap'; |
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 5, 2021
## [24.5.1](v24.5.0...v24.5.1) (2021-02-05) ### Bug Fixes * missing exported types ([#1005](#1005)) ([f6806de](f6806de))
Collaborator
Author
|
🎉 This PR is included in version 24.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [24.5.1](elastic/elastic-charts@v24.5.0...v24.5.1) (2021-02-05) ### Bug Fixes * missing exported types ([opensearch-project#1005](elastic/elastic-charts#1005)) ([352c722](elastic/elastic-charts@352c722))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export some missing types used in Kibana but not exported from the main module