feat(rum-core): enhance user transaction name obtaining#1390
Merged
Conversation
devcorpio
commented
Jul 10, 2023
devcorpio
commented
Jul 10, 2023
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
amannocci
reviewed
Jul 10, 2023
933ffa6 to
6fc8f0c
Compare
devcorpio
commented
Jul 11, 2023
d45cd7b to
20127f2
Compare
vigneshshanmugam
approved these changes
Jul 11, 2023
42c4c63 to
3b0dc7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1286
Summary
We have improved the user-interaction transaction name obtaining. From now on, if a user performs click on an element from a nested HTML structure like this:
The users will always get
Click - my transaction namerather thanClick - spanorClick - svgFor more details see the issue
Important:
The agent will keep applying the older "algorithm" in browsers not supporting the closest method. E.g. IE11
In addition, this will work if the target is inside a button or link - the ones we define as interactive selectors. See the associated tests in case you need more context