Skip to content

feat(rum): add sendCredentials config to TypeScript typings#1243

Merged
devcorpio merged 1 commit intoelastic:mainfrom
stevenhair:forgot-the-types
Jun 15, 2022
Merged

feat(rum): add sendCredentials config to TypeScript typings#1243
devcorpio merged 1 commit intoelastic:mainfrom
stevenhair:forgot-the-types

Conversation

@stevenhair
Copy link
Copy Markdown
Contributor

@stevenhair stevenhair commented Jun 14, 2022

#1238 added the sendCredentials option, but it didn't add it to the Typescript definitions file. This fixes that oversight.

@ghost
Copy link
Copy Markdown

ghost commented Jun 14, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-15T09:19:21.884+0000

  • Duration: 75 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 4740
Skipped 64
Total 4804

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@devcorpio devcorpio changed the title fix: Add sendCredentials option to TS definitions fix: add sendCredentials option to TS definitions Jun 15, 2022
@devcorpio
Copy link
Copy Markdown
Contributor

devcorpio commented Jun 15, 2022 •
edited
Loading

Thanks for this @stevenhair, it will be included on the next release 👍

Btw, I changed the commit message to avoid treating it as a fix. Like we did here

@devcorpio devcorpio changed the title fix: add sendCredentials option to TS definitions feat(rum): add sendCredentials option to TS definitions Jun 15, 2022
@devcorpio devcorpio changed the title feat(rum): add sendCredentials option to TS definitions feat(rum): add sendCredentials config to TypeScript typings Jun 15, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jun 15, 2022

📦 Bundlesize report

Filename Size(bundled) Size(gzip) Diff(gzip)
elastic-apm-opentracing.umd.min.js 66.0 KiB 21.0 KiB 💚 0 Bytes
elastic-apm-rum.umd.min.js 59.9 KiB 19.5 KiB 💚 0 Bytes

@ghost
Copy link
Copy Markdown

ghost commented Jun 15, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 98.039% (50/51) ❕
Classes 98.039% (50/51) ❕
Methods 97.356% (405/416) ❕
Lines 95.343% (2068/2169) ❕
Conditionals 86.482% (1030/1191) ❕

@devcorpio devcorpio merged commit 369800e into elastic:main Jun 15, 2022
@stevenhair stevenhair deleted the forgot-the-types branch June 15, 2022 13:56
@kes2464
Copy link
Copy Markdown

kes2464 commented Jan 23, 2023

Hi @devcorpio, it seems like this hasn't been released yet, do you know when the next release will be?
Thanks

@kes2464 kes2464 mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devcorpio devcorpio devcorpio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevenhair @devcorpio @kes2464