Add a warning to Delimiter::None that rustc currently does not respect it.#455
Merged
dtolnay merged 1 commit intodtolnay:masterfrom May 25, 2024
Merged
Add a warning to Delimiter::None that rustc currently does not respect it.#455dtolnay merged 1 commit intodtolnay:masterfrom
Delimiter::None that rustc currently does not respect it.#455dtolnay merged 1 commit intodtolnay:masterfrom
Conversation
dtolnay
requested changes
Apr 25, 2024
Owner
dtolnay
left a comment
There was a problem hiding this comment.
Could you please add this in proc_macro's documentation to begin with? Then we can mirror it here. I am not interested in the documentation being out of sync.
Contributor
Author
|
Of course. I wasn't aware that it was a mirror of that. I'll follow up here if/when that's done. |
64bc3d9 to
e9aa9d6
Compare
…t it. It does not provide the behaviour it is indicated to provide when used in a proc_macro context. This is a port of rust-lang/rust/124389.
Contributor
Author
|
This is now a port of the accepted rust-lang/rust/pull/124389 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when used to implement a proc_macro,
Delimiter::Nonesimply doesn't do what it is documented to do.While this is a rustc bug (rust-lang/rust#67062), it is a long standing one, and hard to discover.
This pull request adds a warning to inform users of this issue, with a link to the relevant issue, and a version number of the last known affected rustc version.