Trim off spaces in platform string#64
Merged
crazy-max merged 1 commit intodocker:masterfrom Nov 25, 2022
Merged
Conversation
crazy-max
requested changes
Nov 25, 2022
Member
crazy-max
left a comment
There was a problem hiding this comment.
Generated files don't look good, what command did you use? docker buildx bake pre-checkin should fix it.
This allows users to specify platform in a more humane way, for example:
```yaml
env:
# equals to `linux/amd64, linux/arm/v6`
platforms: >
linux/amd64,
linux/arm/v6
- uses: docker/setup-qemu-action@v2
with:
platforms: ${{ env.PLATFORMS }}
```
Signed-off-by: Chocobo1 <Chocobo1@users.noreply.github.com>
Contributor
Author
I just ran
Thanks, done. Hope it is alright now. |
crazy-max
approved these changes
Nov 25, 2022
Member
There was a problem hiding this comment.
LGTM, also platforms you defined in your example will not work. Should be one of these archs: https://github.com/tonistiigi/binfmt/blob/9977509979cd64fea6e1097c9fc096702191c2f3/cmd/binfmt/config.go#L22-L68. Maybe we could be smart enough in binfmt and translate those.
Nevermind we already do this so your example is good: https://github.com/tonistiigi/binfmt/blob/9977509979cd64fea6e1097c9fc096702191c2f3/cmd/binfmt/main.go#L153
scottames
referenced
this pull request
in scottames/dots
Jun 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/setup-qemu-action](https://togithub.com/docker/setup-qemu-action) | action | minor | `v2.1.0` -> `v2.2.0` | --- ### Release Notes <details> <summary>docker/setup-qemu-action</summary> ### [`v2.2.0`](https://togithub.com/docker/setup-qemu-action/releases/tag/v2.2.0) [Compare Source](https://togithub.com/docker/setup-qemu-action/compare/v2.1.0...v2.2.0) #### What's Changed - Trim off spaces in `platforms` input by [@​Chocobo1](https://togithub.com/Chocobo1) in [https://github.com/docker/setup-qemu-action/pull/64](https://togithub.com/docker/setup-qemu-action/pull/64) - Switch to actions-toolkit implementation by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/setup-qemu-action/pull/70](https://togithub.com/docker/setup-qemu-action/pull/70) [https://github.com/docker/setup-qemu-action/pull/80](https://togithub.com/docker/setup-qemu-action/pull/80) [https://github.com/docker/setup-qemu-action/pull/83](https://togithub.com/docker/setup-qemu-action/pull/83) #### New Contributors - [@​Chocobo1](https://togithub.com/Chocobo1) made their first contribution in [https://github.com/docker/setup-qemu-action/pull/64](https://togithub.com/docker/setup-qemu-action/pull/64) **Full Changelog**: docker/setup-qemu-action@v2.1.0...v2.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to specify platform in a more humane way, for example:
Signed-off-by: Chocobo1 Chocobo1@users.noreply.github.com