Enhance documentation#299
Merged
crazy-max merged 1 commit intodocker:masterfrom Feb 17, 2021
Merged
Conversation
|
looks good, and a good description for the topic in #215 |
f866699 to
e97f27a
Compare
Member
|
After the first example can we had a section explaining setup-buildx and setup-qemu are optional and when they are needed. And maybe a link to a longer writeup in the advanced section explaining usage of driver and the main differences(multi-platform, load, cache-export). |
Member
Author
|
@tonistiigi Thanks for your feedback. I will make some changes based on this. |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
e97f27a to
a63b18d
Compare
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 74.39% 74.39%
=======================================
Files 4 4
Lines 164 164
Branches 28 28
=======================================
Hits 122 122
Misses 22 22
Partials 20 20 Continue to review full report at Codecov.
|
tonistiigi
approved these changes
Feb 17, 2021
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #215
And also:
cc @tonistiigi @MarcelCoding @ahmadnassri
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com