make user optional in db connection pool, update acc tests#868
Merged
andrewsomething merged 1 commit intodigitalocean:mainfrom Aug 17, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DO API allows DB pools to be created without a user specified. This PR modifies the
digitalocean_database_connection_poolresource and removes user as a required field. Without user specified, pool uses the connection credentials of the inbound user.Adds new test case for creates w.o specified user,
TestAccDigitalOceanDatabaseConnectionPool_InboundUser, and modifiesTestAccDigitalOceanDatabaseConnectionPool_Basicto cover pool updates.