spaces: Implement support for bucket policy#800
Merged
andrewsomething merged 2 commits intodigitalocean:mainfrom Mar 8, 2022
Merged
spaces: Implement support for bucket policy#800andrewsomething merged 2 commits intodigitalocean:mainfrom
andrewsomething merged 2 commits intodigitalocean:mainfrom
Conversation
ChiefMateStarbuck
approved these changes
Mar 7, 2022
andrewsomething
approved these changes
Mar 8, 2022
Member
andrewsomething
left a comment
There was a problem hiding this comment.
👍 Great stuff! Thanks @pavelkovar!
|
Hey, @pavelkovar - Thanks a ton for this sweet PR! 😄 Would you please shoot me an email when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
digitalocean_spaces_bucket_policyresource, which allows to attach bucket policy to Spaces. It works similar to theaws_s3_bucket_policyresource.This change adds a new dependency on the hashicorp/awspolicyequivalence module that requires update of the aws/aws-sdk-go module.