Fetch loadbalancer resource in datasource by ID#773
Merged
andrewsomething merged 4 commits intodigitalocean:mainfrom Jan 10, 2022
Merged
Fetch loadbalancer resource in datasource by ID#773andrewsomething merged 4 commits intodigitalocean:mainfrom
andrewsomething merged 4 commits intodigitalocean:mainfrom
Conversation
andrewsomething
approved these changes
Jan 10, 2022
Member
andrewsomething
left a comment
There was a problem hiding this comment.
👍 Looks great. Thanks for the contribution!
I did add one additional commit to use unique tag names in the acceptance tests. This is useful if the tests are run in parallel so that Droplets from one test are not added to load balancers from another.
andyli
added a commit
to HaxeFoundation/haxe-terraform
that referenced
this pull request
Jan 11, 2022
|
Just tried it - works perfectly. Thanks! |
andyli
added a commit
to HaxeFoundation/haxe-terraform
that referenced
this pull request
Jan 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #772
Currently we can fetch loadbalancer resource in datasource by only its name.
https://registry.terraform.io/providers/digitalocean/digitalocean/latest/docs/data-sources/loadbalancer
By this update, we will be able to fetch loadbalancer resource by its ID in addition to name like below.
This update is referring to the following droplet datasource.
https://github.com/digitalocean/terraform-provider-digitalocean/blob/main/digitalocean/datasource_digitalocean_droplet.go#L40