Skip to content

floating_ip_assignment: Properly support importing existing assignments.#771

Merged
andrewsomething merged 2 commits intomainfrom
asb/issues/763
Jan 5, 2022
Merged

floating_ip_assignment: Properly support importing existing assignments.#771
andrewsomething merged 2 commits intomainfrom
asb/issues/763

Conversation

@andrewsomething
Copy link
Copy Markdown
Member

floating_ip_assignment resources currently use schema.ImportStatePassthrough for importing. This is meant for use when an ID-only refresh is possible. It would have never worked for this resource which needs both the floating IP and the Droplet ID.

Fixes: #763

@andrewsomething andrewsomething requested a review from a team January 4, 2022 23:38
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests January 4, 2022 23:39 Inactive
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests January 4, 2022 23:45 Inactive
Copy link
Copy Markdown
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewsomething andrewsomething merged commit bb2cfd0 into main Jan 5, 2022
@andrewsomething andrewsomething deleted the asb/issues/763 branch January 5, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform floating IP assignment import leads to crash

2 participants