Skip to content

vpc: Allow updating name and description of default vpcs.#748

Merged
andrewsomething merged 1 commit intomainfrom
asb/issues/747
Nov 12, 2021
Merged

vpc: Allow updating name and description of default vpcs.#748
andrewsomething merged 1 commit intomainfrom
asb/issues/747

Conversation

@andrewsomething
Copy link
Copy Markdown
Member

@andrewsomething andrewsomething commented Nov 12, 2021

The PUT request for updating a VPC needs to include the default attribute even if it is not changed in order to support updating the name or description of a region's default vpc.

Fixes: #747

@andrewsomething andrewsomething requested a review from a team November 12, 2021 15:27
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests November 12, 2021 15:29 Inactive
Copy link
Copy Markdown
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsomething andrewsomething merged commit 7c5b9e6 into main Nov 12, 2021
@andrewsomething andrewsomething deleted the asb/issues/747 branch November 12, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot rename default vpc

2 participants