load-balancers: Add support for size_unit#742
Merged
bentranter merged 2 commits intodigitalocean:mainfrom Nov 8, 2021
Merged
Conversation
b0a575e to
84d6635
Compare
bentranter
requested changes
Nov 5, 2021
Member
bentranter
left a comment
There was a problem hiding this comment.
Changes look great but could you update the tests as well for the new size_unit field? Thanks!
84d6635 to
130b7a1
Compare
Contributor
Author
|
@bentranter done! Also added a test for using just |
andrewsomething
requested changes
Nov 5, 2021
Member
andrewsomething
left a comment
There was a problem hiding this comment.
resource_digitalocean_loadbalancer_test.go:113: Step 2/2 error: Check failed: 1 error occurred:
* Check 4/13 error: digitalocean_loadbalancer.foobar: Attribute 'size' not found
--- FAIL: TestAccDigitalOceanLoadbalancer_Updated (284.68s)
Looks like this one needs updating as well:
(GitHub won't let you comment on an unchanged line.)
Also noticing this one failing:
resource_digitalocean_loadbalancer_test.go:471: Step 2/2, expected an error but got none
--- FAIL: TestAccDigitalOceanLoadbalancer_resizeExpectedFailure (104.86s)
Does the policy around resizing change with this release?
- Fix tests
Contributor
Author
Fixed this one up!
We still have the same policy around resizing, but fixed the issue by moving the param to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.