Assign and remove project resources without unnecessary churn (Fixes: #585).#586
Merged
andrewsomething merged 5 commits intomainfrom Feb 18, 2021
Merged
Assign and remove project resources without unnecessary churn (Fixes: #585).#586andrewsomething merged 5 commits intomainfrom
andrewsomething merged 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation moves all resources in the old config to the default project and then adds the resources in the new config to the Terraform-managed project. This creates a lot of unnecessary churn.
terraform-provider-digitalocean/digitalocean/resource_digitalocean_project.go
Lines 208 to 209 in 2c4bf56
This PR adds a helper function to compares two
*schema.Sets, producing lists of which should be added and which should be removed. Resources that were in both the old and new configs will no longer be touched.Fixes: #585