Skip to content

Fix container registry creation and support updating subscription plans.#516

Merged
andrewsomething merged 3 commits intomasterfrom
docr-updates
Nov 6, 2020
Merged

Fix container registry creation and support updating subscription plans.#516
andrewsomething merged 3 commits intomasterfrom
docr-updates

Conversation

@andrewsomething
Copy link
Copy Markdown
Member

@andrewsomething andrewsomething commented Nov 5, 2020

When registry support went into general availability, it added the requirement of specifying a subscription plan. This adds the subscription_tier_slug to both the resource and data source allowing it to be specified on create and updated.

$ make testacc TESTARGS=-run='ContainerRegistry'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=ContainerRegistry -timeout 120m
?       github.com/digitalocean/terraform-provider-digitalocean [no test files]
=== RUN   TestAccDataSourceDigitalOceanContainerRegistry_Basic
=== PAUSE TestAccDataSourceDigitalOceanContainerRegistry_Basic
=== RUN   TestAccDigitalOceanContainerRegistry_importBasic
--- PASS: TestAccDigitalOceanContainerRegistry_importBasic (19.08s)
=== RUN   TestAccDigitalOceanContainerRegistryDockerCredentials_Basic
--- PASS: TestAccDigitalOceanContainerRegistryDockerCredentials_Basic (17.92s)
=== RUN   TestAccDigitalOceanContainerRegistryDockerCredentials_withExpiry
--- PASS: TestAccDigitalOceanContainerRegistryDockerCredentials_withExpiry (17.73s)
=== RUN   TestAccDigitalOceanContainerRegistry_Basic
--- PASS: TestAccDigitalOceanContainerRegistry_Basic (20.75s)
=== CONT  TestAccDataSourceDigitalOceanContainerRegistry_Basic
--- PASS: TestAccDataSourceDigitalOceanContainerRegistry_Basic (22.86s)
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/digitalocean    98.358s
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/datalist       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/setutil        (cached) [no tests to run]

bentranter
bentranter approved these changes Nov 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andrewsomething andrewsomething merged commit f418ee2 into master Nov 6, 2020
@andrewsomething andrewsomething deleted the docr-updates branch November 6, 2020 16:08
@tomaszmichalak tomaszmichalak mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentranter bentranter bentranter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewsomething @bentranter