add digitalocean_domains data source#484
Merged
andrewsomething merged 3 commits intodigitalocean:masterfrom Sep 22, 2020
Merged
add digitalocean_domains data source#484andrewsomething merged 3 commits intodigitalocean:masterfrom
andrewsomething merged 3 commits intodigitalocean:masterfrom
Conversation
Contributor
Author
|
If #481 lands first, then the |
Member
|
I've merged #481, so the FilterKeys and SortKeys fields can now be removed here too. |
caf4d17 to
fe00891
Compare
andrewsomething
approved these changes
Sep 22, 2020
Member
andrewsomething
left a comment
There was a problem hiding this comment.
I somehow missed that you did the rebase here. Sorry for the long delay in merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
digitalocean_domainsdata source as the list version ofdigitalocean_domain. This data source is not as useful it could be sincedatalistdoes not support regex or substring matching yet.