Increase timeout on VPC deletion retry.#455
Merged
andrewsomething merged 1 commit intomasterfrom Jul 8, 2020
Merged
Conversation
MasonEgger
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a lag between when a resource is deleted and when it is de-registered from the VPC service can be observed. We currently will retry failed VPC delete requests for one minute before timing out. This PR raises the default to two minutes and makes it user configurable. I'm reluctant to raise the default to a much larger value as this can be a legitimate error (e.g. a Droplet created in the control panel was added to a VPC managed with Terraform).
This should help to resolve https://github.com/terraform-providers/terraform-provider-digitalocean/issues/446