Skip to content

DBAAS-3011: Add new public endpoints for dbaas alerts#564

Merged
andrewsomething merged 4 commits intodigitalocean:mainfrom
dweinshenker:dbaas-3011-monitoring-api
Oct 12, 2022
Merged

DBAAS-3011: Add new public endpoints for dbaas alerts#564
andrewsomething merged 4 commits intodigitalocean:mainfrom
dweinshenker:dbaas-3011-monitoring-api

Conversation

@dweinshenker
Copy link
Copy Markdown
Contributor

@dweinshenker dweinshenker commented Oct 11, 2022

Adding new public DBAAS rule endpoints to allow doctl to validate when creating/updating rules

@dweinshenker dweinshenker marked this pull request as ready for review October 12, 2022 17:00
Copy link
Copy Markdown
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

It would be great to get these added to the OpenAPI spec so that they show up in the public API documentation and clients generated from it:

https://github.com/digitalocean/openapi/blob/24d640763881c4d84c5cdab1656e695485e23120/specification/resources/monitoring/models/alert_policy.yml#L44-L60

@andrewsomething andrewsomething merged commit 3c0c036 into digitalocean:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants