Separate ESM/CJS TS definitions, bump esm2umd#121
Merged
dcodeIO merged 1 commit intodcodeIO:mainfrom Apr 15, 2023
russellsteadman:main
Merged
Separate ESM/CJS TS definitions, bump esm2umd#121dcodeIO merged 1 commit intodcodeIO:mainfrom russellsteadman:main
dcodeIO merged 1 commit intodcodeIO:mainfrom
russellsteadman:main
Conversation
Owner
|
I guess it's not a problem when the UMD typings reexport an Lines 1 to 2 in 3cea40d |
Contributor
Author
|
I think that is the case. This might be good to test out -- I can add in some tests / just independently confirm. Currently though the package cannot be imported when using ESM and TypeScript. @dcodeIO |
Contributor
Author
|
@dcodeIO This does work when I tested it for both CommonJS and ESM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #109 as discussed in #109 (comment). Also bumped patch version of
esm2umdto remove 2 security vulnerabilities.