fix: Fix error when testing cross-origin code#685
fix: Fix error when testing cross-origin code#685mschile merged 11 commits intocypress-io:masterfrom
Conversation
|
|
@Nojay-Games Thanks for the contribution! Can you write a test to cover the logic for the fix you wrote? |
|
That fix is what I need, there is no way to merge it into production so I can update the dependency solve the conflict I have with the library when doing my tests? thanks! |
|
@Nojay-Games Will you have time to write a test for this? If the PR is incomplete, we'll have to close this. |
|
@jennifer-shehane logs are expired and i cannot understand whats wrong in tests, is ok for u to rerun the merge so we can see whats going wrong? |
|
@alecmestroni I pushed an empty commit. I believe the original ask was to write a test case that tests the added behavior here. Since there's nothing confirming this fixes the behavior or prevents regressions from being introduced. |
@jennifer-shehane Sadly its not an error during the test but its a permission bug related to the account used |
|
@alecmestroni Yah, the snyk failure can be ignored. It doesn't run properly for contributors. |
@jennifer-shehane so tests are passing and merge can be applied |
|
@alecmestroni There is no test for the change in behavior here verifying the behavior at all. |
|
@jennifer-shehane test added Nojay-Games#1 |
|
@jennifer-shehane any news? |
|
@alecmestroni - @mschile is assigned to review this is he finds some extra time. Thanks for your patience. |
|
@jennifer-shehane he has done the changing. please approve them |
|
@Nojay-Games thank you for this one, I just found this problem and it's super annyoing! @alecmestroni and thank you for the tests! @jennifer-shehane could you push this? |
|
@alecmestroni and @lhimstedt, the tests are failing, so I still need to investigate that before this PR can be merged. |
|
🎉 This PR is included in version 3.12.40 🎉 The release is available on: Your semantic-release bot 📦🚀 |
When testing cross-origin websites with
cy.origin(), the following error gets thrown:DOMException: Blocked a frame with origin "http://localhost:3000" from accessing a cross-origin frame.This occurs when accessing
win.__coverage__in the code. Since you don't control cross-origin code and it therefore doesn't need code coverage, you can simply ignore the code coverage if accessingwin.__coverage__throws an error.