fix(postcss-colormin): Strict color parsing#1122
Conversation
alexander-akait
left a comment
There was a problem hiding this comment.
Let's add tests to ensure we don't break it again 👍
|
How do you work with the integration tests BTW? They are HUGE and it seems impossible to check them. |
Agree, we need improve them, right now you can use smart diff locally and found which characters was changed (and maybe found regression) |
|
Ooof. Your integrations tests are killing me 🙃
Help would be really appreciated since I'm a rookie in the repo. |
|
git diff --word-diff
…On Fri, 21 May 2021, 16:00 Vlad Shilov, ***@***.***> wrote:
Ooof. Your integrations tests are killing me 🙃
1. What is smart diff? Can't google the thing)
2. How to update integration snapshots properly?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1122 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKUJKXE2IKZLSA4XD6WQLTOZRRBANCNFSM45JDZWZQ>
.
|
|
Snapshots are fixed (tons of So we should be ready to go! |
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
- Coverage 96.37% 96.36% -0.01%
==========================================
Files 115 115
Lines 3582 3575 -7
Branches 1054 1051 -3
==========================================
- Hits 3452 3445 -7
Misses 121 121
Partials 9 9
Continue to review full report at Codecov.
|
|
/cc @ludofischer can you look too? I think we need do release after merge |
ludofischer
left a comment
There was a problem hiding this comment.
Seems straightforward enough to me. Let's try and release this!
|
Thanks a lot @omgovich for your hard work! |
|
Thanks for the quick work on this guys. |
|
Always glad to help. Let me know if you need something else :) |
Fixes #1120
Fixes #1115
Fixes #1113
Colord v2 conforms to CSS Color Level Specs and ignores invalid
<color>values, so upgrading will fix all of the issues we got last few days.See omgovich/colord#53 for more details.