pkg/unshare: fix implicit declaration of basename function#1920
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom May 13, 2024
nmeum:libgen-basename
Merged
pkg/unshare: fix implicit declaration of basename function#1920openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom nmeum:libgen-basename
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
nmeum:libgen-basename
Conversation
POSIX requires the prototype of the basename function to be declared in the libgen.h header file. Therefore, this header file needs to be included in order to make use of this function in a POSIX environment. Some implementations, e.g. glibc, also define this function in string.h. However, musl (for example) only defines it in libgen.h causing it be implicitly declared (with an `int` return type) which is by no means cosmetic and can lead to severe miscompilations. Signed-off-by: Sören Tempel <soeren+git@soeren-tempel.net>
saschagrunert
approved these changes
May 13, 2024
Member
|
@nmeum may I ask you to DCO sign-off your commit? |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmeum, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
Oppsi, sorry forgot about that! Should be fixed now :) |
Member
|
LGTM |
Member
|
/lgtm |
Member
|
Thanks @nmeum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX requires the prototype of the basename function to be declared in the libgen.h header file. Therefore, this header file needs to be included in order to make use of this function in a POSIX environment. The
unshare.csource file uses this function here (without includinglibgen.h):storage/pkg/unshare/unshare.c
Line 235 in b193f00
Some implementations, e.g. glibc, also define this function in string.h. However, musl (for example) only defines it in libgen.h causing it be implicitly declared (with an
intreturn type) which is by no means cosmetic and can lead to severe miscompilations.