chunked: skip cache file for non-partial layers#1910
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Apr 24, 2024
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Luap99
reviewed
Apr 24, 2024
if the layer does not have a manifest TOC, just ignore it instead of raising a warning. There is no need to create a cache file since there is no manifest file to parse. Closes: containers#1909 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
af0e73b to
881107d
Compare
Member
|
/lgtm |
mtrmac
reviewed
Apr 24, 2024
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Technically this works — but I’d really expect the early exit to be, well, more early.
Historically bigDataKey was used before we added chunkedLayerDataKey, so maybe start reading bigDataKey, and immediately cleanly exit if that one is missing; then we can optionally load the other one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the layer does not have a manifest TOC, just ignore it instead of raising a warning. There is no need to create a cache file since there is no manifest file to parse.
Closes: #1909