Skip to content

chunked: fix divide by zero in bloom filter#1904

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
giuseppe:chunked-fix-divide-by-zero
Apr 23, 2024
Merged

chunked: fix divide by zero in bloom filter#1904
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
giuseppe:chunked-fix-divide-by-zero

Conversation

@giuseppe
Copy link
Copy Markdown
Member

if the bloom filter size is zero, the "% size" operation fails with a divide by zero.

Closes: #1903

if the bloom filter size is zero, the "% size" operation fails with a
divide by zero.

Closes: containers#1903

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the chunked-fix-divide-by-zero branch from 5410d8c to 364ff49 Compare April 23, 2024 11:54
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Apr 23, 2024

lgtm
@mtrmac @nalind @saschagrunert @flouthoc PTAL

Copy link
Copy Markdown
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c78883f into containers:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

composefs: podman pull multiple: panic, integer divide by zero

4 participants