composefs: return mkcomposefs stderr as part of error#1890
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Apr 18, 2024
Merged
composefs: return mkcomposefs stderr as part of error#1890openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
Writing the error to stderr is not helpful when using the podman API. The error would only be visable on the server which is bad and likely is not noticed at all. Also for the regular podman cli it would be hard for a user to know if the stderr from mkcompose is related to the returned podman error. To fix this capture the stderr and append it to the error as string, this should be fine assuming mkcomposefs doesn't print a ton on stderr which I assume is not the case. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
|
LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing the error to stderr is not helpful when using the podman API. The error would only be visable on the server which is bad and likely is not noticed at all.
Also for the regular podman cli it would be hard for a user to know if the stderr from mkcompose is related to the returned podman error.
To fix this capture the stderr and append it to the error as string, this should be fine assuming mkcomposefs doesn't print a ton on stderr which I assume is not the case.