store: lock stores before calling Exists#1877
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Apr 8, 2024
Merged
store: lock stores before calling Exists#1877openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
mtrmac
reviewed
Apr 8, 2024
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Thanks for the followup!
we need to lock the stores for read before checking if a layer exists. follow up for 466ee04 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
ebf7367 to
721d67a
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we need to lock the stores for read before checking if a layer exists.
follow up for 466ee04
addressing the comment here: #1873 (comment)