Skip to content

Cirrus-CI: Give success a name#1860

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
cevich:update_success
Mar 14, 2024
Merged

Cirrus-CI: Give success a name#1860
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
cevich:update_success

Conversation

@cevich
Copy link
Member

@cevich cevich commented Mar 13, 2024

This and the referenced openshift/release PR will make prow (via the tide bot) block merges unless the success aggregation task is green. This must be configured independently from branch-protection rules which tide does/can not manage due to write-only access.

This and the referenced openshift/release PR will make prow (via the
tide bot) block merges unless the success aggregation task is green.
This must be configured independently from branch-protection rules which
tide does/can not manage due to write-only access.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Member Author

cevich commented Mar 13, 2024

Note to me: Once this merges, the branch-protection rule for main needs to be updated to use the new name (matching tide).

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, giuseppe, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cevich,giuseppe,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich
Copy link
Member Author

cevich commented Mar 14, 2024

(github branch-protection settings have been updated)

@nalind
Copy link
Member

nalind commented Mar 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c38e653 into containers:main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants