Short-term kludges for recent AdditionalLayerStore changes#2428
Merged
rhatdan merged 3 commits intocontainers:mainfrom May 21, 2024
Merged
Short-term kludges for recent AdditionalLayerStore changes#2428rhatdan merged 3 commits intocontainers:mainfrom
rhatdan merged 3 commits intocontainers:mainfrom
Conversation
Well, we trust it _anyway_ to actually validate the TOC digest and enforce layer consistency, but it's simpler to use the known-trusted value than to worry about the backend's trust. Also add a FIXME about the case when the value is "". Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This shouldn't matter in practice because the returned struct happens to be a copy, but that's not promised by the API. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…layer ... but silently ignore the ALS layer. Also add a FIXME. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Collaborator
Author
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #2416, partially addresses some of the concerns, and adds FIXMEs for other aspects.
Hopefully we can have better fixes over time.
See individual commit messages for details.