Non-security digest.Digest use cleanups#2410
Merged
giuseppe merged 7 commits intocontainers:mainfrom May 14, 2024
Merged
Conversation
Should not actually change behavior, the value is never set. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
These cases should be safe because the data is either trusted (ostree), or validated by an exact match later (signatures) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... so that we can simplify the error handling paths. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Use the ordinary digest.Parse() instead of separate digest.Validate() and conversions. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
1944cce to
496e3af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of cleanups around creating/validating
digest.Digestvalues, in places where it should not be exploitable.See individual commit messages for details.
A side effect of the code audit required by CVE-2024-3727 .