Allow using recent opencontainers/go-digest#2406
Merged
rhatdan merged 2 commits intocontainers:mainfrom May 14, 2024
Merged
Conversation
cae3943 to
5501f1b
Compare
mheon
reviewed
May 13, 2024
pkg/blobinfocache/sqlite/sqlite.go
Outdated
| // | ||
| // We use the fairly wasteful text with hexadecimal digits because digest.Digest does not define a binary representation; | ||
| // and the way digest.Digest.Hex() is deprecated in favor of digest.Digest.Encoded(), and the way digest.Algorithm | ||
| // and the way digest.Digest.Encoded() is deprecated in favor of digest.Digest.Encoded(), and the way digest.Algorithm |
Collaborator
Author
There was a problem hiding this comment.
Good catch, thanks!
5501f1b to
3690153
Compare
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
3690153 to
b71a3e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to update opencontainers/go-digest to include opencontainers/go-digest#101 , if it is accepted, to further protect against things like CVE-2024-3727 .
The upstream branch has deprecated the
Hexmethod, so migrate away. Also ensure we can work with the proposed digest validation.