Add a helper for formatting multiple errors#2365
Merged
rhatdan merged 4 commits intocontainers:mainfrom Apr 5, 2024
Merged
Conversation
It's sad that this is even necessary, but using fmt.Errorf with an []error is way too inconvenient without a helper. Only adds a new function, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This may make errors visible to errors.As/errors.Is This commit, in general, attempts not to change the formatting; only in newShortNameAliasCache, the order of the errors is no longer reversed. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Don't treat the first error specially. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Go 1.20, the standard library supposedly contains infrastructure for reporting multiple errors.
Sadly, that infrastructure is mostly unhelpful:
errors.Joingives no control over formatting, andfmt.Errorfdoes not support a[]errorinput. So, introduce our ownmultierr.Format, and use it where possible.Then remove the
go-multierrordependency. The net result is not particularly better code, but at least we try to work with the standard library design.(This was originally motivated just by trying to remove the
go-multierrordependency in #2364, now that the standard library supposedly supports the feature.)This might, in some cases, change whether the returned error matches
errors.{As,Is}, mostly because the previous code for aggregating multiple errors was written before Go 1.20 made it possible for multiple errors to match. (Not that I know how the multi-matching design can ever be all that useful…)See individual commit messages for details.