chore(deps): update dependency containers/automation_images to v20240320#2354
Merged
chore(deps): update dependency containers/automation_images to v20240320#2354
Conversation
Member
|
Failure in validate:
|
Collaborator
That’s quite possibly some old cruft in |
Collaborator
|
Trying to update this, following in the footsteps of #2355 . |
edsantiago
approved these changes
Mar 21, 2024
| .install.gitvalidation: | ||
| if [ ! -x "$(GOBIN)/git-validation" ]; then \ | ||
| GO111MODULE="off" go get $(BUILDFLAGS) github.com/vbatts/git-validation; \ | ||
| go install github.com/vbatts/git-validation@latest; \ |
Member
There was a problem hiding this comment.
Thanks, this is obviously the part I missed. LGTM.
mtrmac
approved these changes
Mar 21, 2024
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This use of (go get) was deprecated back in Go 1.18. Also don't use our build tags for building unrelated tools. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
It's the default since Go 1.16. In theory the environment might be setting it to off, and breaking our builds; unless something compelling comes up, I think that hypothetical environment should be changed, nowadays. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
9a46c6a to
b6b60bf
Compare
edsantiago
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
20240125t184057z-f39f38d13->20240320t153921z-f39f38d13Release Notes
containers/automation_images (containers/automation_images)
v20240320t153921z-f39f38d13Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.