Add support for Docker HealthConfig.StartInterval (v25.0.0+)#2345
Merged
mtrmac merged 1 commit intocontainers:mainfrom Mar 18, 2024
Merged
Conversation
Signed-off-by: Mikhail Sokolov <msokolov@evolution.com>
mtrmac
approved these changes
Mar 15, 2024
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
This looks about right, and it might be sufficient for some purposes.
For other purposes:
- Docker now uses, and interprets, the fields also in OCI images, not just schema2. So we should be able to decode and use those fields in that situation (… arguably there might be some benefit in intentionally refusing to support that, but that’s probably not ultimately helpful to users)
- And to support both formats, the general c/image abstractions should allow doing that without an image consumer having to specifically support individual manifest types. That would probably mean adding corresponding fields to
types.ImageInspectInfo, and updatingInspectto populate them.
But all of that can come later, this is already valuable as is.
Contributor
Author
|
@mtrmac thank you! I can add the fields in other places if you think it should be done. But I'm a bit out of my depth here - I haven't found anything "health" related in |
Collaborator
|
Yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to add support for Dockerfile HEALTHCHECK --start-interval param which has been added in Docker v25.0.0.
So I figured out I have to update this library as well.
The change is quite trivial but I couldn't say that I understand completely what I'm doing so feedback is appreciated.