resetting the elapsed time also resets ETA#538
Merged
djc merged 1 commit intoconsole-rs:mainfrom May 9, 2023
Merged
Conversation
djc
reviewed
May 7, 2023
Member
|
@chris-laplante further feedback welcome! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sense to reset the ETA without resetting the time elapsed back to zero, but when setting the time elapsed back to zero, the ETA should also be reset as this should make the progress bar behave as if it had just been activated (in a partially complete state).
Fixes #536.