Skip to content

Allow rate-limiting TermLike targets#526

Merged
chris-laplante merged 1 commit intoconsole-rs:mainfrom
akx:rate-limited-term-like
Mar 24, 2023
Merged

Allow rate-limiting TermLike targets#526
chris-laplante merged 1 commit intoconsole-rs:mainfrom
akx:rate-limited-term-like

Conversation

@akx
Copy link
Copy Markdown
Contributor

@akx akx commented Mar 21, 2023

This adds an optional rate_limiter to custom TermLike targets, so they don't need to implement rate limiting by hand.

Copy link
Copy Markdown
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks! @chris-laplante any thoughts?

@djc djc requested a review from chris-laplante March 21, 2023 16:23
Copy link
Copy Markdown
Collaborator

@chris-laplante chris-laplante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@chris-laplante chris-laplante merged commit 2b02626 into console-rs:main Mar 24, 2023
@djc djc mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants