Skip to content

fix(app): Fix enum member types parsing#1159

Merged
vogloblinsky merged 1 commit into
compodoc:developfrom
pawtwa:fix-enum-member-types-parsing
Dec 9, 2021
Merged

fix(app): Fix enum member types parsing#1159
vogloblinsky merged 1 commit into
compodoc:developfrom
pawtwa:fix-enum-member-types-parsing

Conversation

@pawtwa

@pawtwa pawtwa commented Dec 1, 2021

Copy link
Copy Markdown

Fix matching the default value and radio options for any @input() of enum type

@pawtwa

pawtwa commented Dec 1, 2021

Copy link
Copy Markdown
Author

@vogloblinsky here is the another case

@vogloblinsky

Copy link
Copy Markdown
Contributor

Could you add a integration test please ?

@pawtwa

pawtwa commented Dec 1, 2021

Copy link
Copy Markdown
Author

Oki, I will, a little bit later

@vogloblinsky

Copy link
Copy Markdown
Contributor

Thanks

@pawtwa

pawtwa commented Dec 8, 2021

Copy link
Copy Markdown
Author

I am back, I gonna write the test @vogloblinsky

@pawtwa pawtwa force-pushed the fix-enum-member-types-parsing branch from d7bbbf5 to 8ff0582 Compare December 8, 2021 16:30
@pawtwa

pawtwa commented Dec 8, 2021

Copy link
Copy Markdown
Author

@vogloblinsky I have just pushed the changes

@pawtwa pawtwa force-pushed the fix-enum-member-types-parsing branch 2 times, most recently from 1ab86ef to ac9d740 Compare December 8, 2021 16:35
Fix matching the default value and radio options for any @input() of enum type
@pawtwa pawtwa force-pushed the fix-enum-member-types-parsing branch from ac9d740 to 7509681 Compare December 8, 2021 17:06
@vogloblinsky

Copy link
Copy Markdown
Contributor

Thanks for the test and the PR

@vogloblinsky vogloblinsky merged commit a4bc151 into compodoc:develop Dec 9, 2021
@pawtwa

pawtwa commented Dec 9, 2021

Copy link
Copy Markdown
Author

@vogloblinsky thanks for accepting the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants