fix(transformers): Ability to transform any with TypeTransformer#956
Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom Jun 12, 2023
disq:fix/ability_to_transform_any
Merged
fix(transformers): Ability to transform any with TypeTransformer#956kodiakhq[bot] merged 4 commits intocloudquery:mainfrom disq:fix/ability_to_transform_any
any with TypeTransformer#956kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
disq:fix/ability_to_transform_any
Conversation
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 52.68% 52.81% +0.13%
==========================================
Files 62 62
Lines 6332 6337 +5
==========================================
+ Hits 3336 3347 +11
+ Misses 2691 2685 -6
Partials 305 305
☔ View full report in Codecov by Sentry. |
disq
commented
Jun 7, 2023
| } | ||
| } | ||
| if columnType == nil { | ||
| return nil // ignored |
Member
Author
There was a problem hiding this comment.
This ensures backwards compatibility with the current situation where we ignore reflect.Interface early in isTypeIgnored.
disq
commented
Jun 7, 2023
| return arrow.ListOf(elemValueType), nil | ||
|
|
||
| case reflect.Interface: | ||
| return nil, nil // silently ignore |
Member
Author
There was a problem hiding this comment.
This ensures we don't panic now that we don't ignore this kind in isTypeIgnored.
hermanschaaf
reviewed
Jun 7, 2023
| } | ||
| for _, exc := range tt.want.Columns { | ||
| if c := table.Column(exc.Name); c == nil { | ||
| t.Fatalf("column %q not found. want: %v", exc.Name, exc.Type) |
hermanschaaf
approved these changes
Jun 7, 2023
Member
Author
|
Ran this on all source plugins - no changes. |
yevgenypats
approved these changes
Jun 12, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
🤖 I have created a release *beep* *boop* --- ## [3.10.5](v3.10.4...v3.10.5) (2023-06-13) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 0f7bd3b ([#961](#961)) ([21f3b68](21f3b68)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 6b7fa9c ([#962](#962)) ([78eecf2](78eecf2)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 71dfe94 ([#953](#953)) ([b48ae1a](b48ae1a)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 7f6aaff ([#963](#963)) ([8c7acdd](8c7acdd)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 8f72077 ([#958](#958)) ([6f6c993](6f6c993)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 90670b8 ([#955](#955)) ([047ab30](047ab30)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b359e74 ([#960](#960)) ([7e95e7d](7e95e7d)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d8eacf8 ([#966](#966)) ([2d32679](2d32679)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to e258cfb ([#957](#957)) ([df842e0](df842e0)) * **transformers:** Ability to transform `any` with TypeTransformer ([#956](#956)) ([c989c28](c989c28)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plus testing fixes.
Without this there was no way to transform
any(unless it's defined as[]any) because bare interfaces were ignored inisTypeIgnored()along with channels/funcs/unsafeptrs.