Skip to content

fix: Remove uint validation#942

Merged
kodiakhq[bot] merged 1 commit intomainfrom
fix/remove_validation
Jun 2, 2023
Merged

fix: Remove uint validation#942
kodiakhq[bot] merged 1 commit intomainfrom
fix/remove_validation

Conversation

@yevgenypats
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats commented Jun 2, 2023

Removing this for now until we change int64 to uint64 in applicable sources. In any case this doesn't have any affect on destinations such as postgres

@yevgenypats yevgenypats requested review from bbernays and disq June 2, 2023 15:11
@github-actions github-actions bot added the fix label Jun 2, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 2, 2023

⏱️ Benchmark results

Comparing with 7eaf327

  • DefaultConcurrencyDFS-2 resources/s: 11,307 ⬆️ 8.53% increase vs. 7eaf327
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,274 ⬇️ 1.20% decrease vs. 7eaf327
  • Glob-2 ns/op: 195.6 ⬇️ 8.23% decrease vs. 7eaf327
  • TablesWithChildrenDFS-2 resources/s: 27,639 ⬇️ 2.34% decrease vs. 7eaf327
  • TablesWithChildrenRoundRobin-2 resources/s: 25,708 ⬇️ 0.32% decrease vs. 7eaf327
  • TablesWithRateLimitingDFS-2 resources/s: 28.33 ⬇️ 0.81% decrease vs. 7eaf327
  • TablesWithRateLimitingRoundRobin-2 resources/s: 830.5 ⬇️ 0.47% decrease vs. 7eaf327

@github-actions github-actions bot added fix and removed fix labels Jun 2, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (7eaf327) 52.25% compared to head (31d308a) 52.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
+ Coverage   52.25%   52.30%   +0.04%     
==========================================
  Files          62       62              
  Lines        6331     6325       -6     
==========================================
  Hits         3308     3308              
+ Misses       2717     2712       -5     
+ Partials      306      305       -1     
Impacted Files Coverage Δ
scalar/int.go 63.59% <ø> (+1.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kodiakhq kodiakhq bot merged commit 4df3b46 into main Jun 2, 2023
@kodiakhq kodiakhq bot deleted the fix/remove_validation branch June 2, 2023 15:21
kodiakhq bot pushed a commit that referenced this pull request Jun 2, 2023
🤖 I have created a release *beep* *boop*
---


## [3.10.2](v3.10.1...v3.10.2) (2023-06-02)


### Bug Fixes

* Remove uint validation ([#942](#942)) ([4df3b46](4df3b46))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants