Skip to content

fix: Use backtick around types#908

Merged
kodiakhq[bot] merged 1 commit intomainfrom
fix-docs
May 26, 2023
Merged

fix: Use backtick around types#908
kodiakhq[bot] merged 1 commit intomainfrom
fix-docs

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

Nextra isn't happy about us including < and > inside the types column now, it thinks it's HTML. This is causing errors on the website, so we need to escape these strings with backticks to avoid this issue.

@hermanschaaf hermanschaaf requested a review from yevgenypats as a code owner May 26, 2023 14:29
@github-actions github-actions bot added the fix label May 26, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c42517e) 47.62% compared to head (5639532) 47.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #908   +/-   ##
=======================================
  Coverage   47.62%   47.62%           
=======================================
  Files          55       55           
  Lines        5134     5134           
=======================================
  Hits         2445     2445           
  Misses       2426     2426           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown

⏱️ Benchmark results

Comparing with c42517e

  • DefaultConcurrencyDFS-2 resources/s: 10,517 ⬇️ 6.00% decrease vs. c42517e
  • DefaultConcurrencyRoundRobin-2 resources/s: 11,133 ⬇️ 6.08% decrease vs. c42517e
  • Glob-2 ns/op: 194.5 ⬇️ 15.78% decrease vs. c42517e
  • TablesWithChildrenDFS-2 resources/s: 28,271 ⬆️ 11.30% increase vs. c42517e
  • TablesWithChildrenRoundRobin-2 resources/s: 25,567 ⬆️ 3.11% increase vs. c42517e
  • TablesWithRateLimitingDFS-2 resources/s: 28.2 ⬇️ 0.11% decrease vs. c42517e
  • TablesWithRateLimitingRoundRobin-2 resources/s: 852.7 ⬇️ 0.70% decrease vs. c42517e

@kodiakhq kodiakhq bot merged commit 858fe54 into main May 26, 2023
@kodiakhq kodiakhq bot deleted the fix-docs branch May 26, 2023 14:34
kodiakhq bot pushed a commit that referenced this pull request May 26, 2023
🤖 I have created a release *beep* *boop*
---


## [3.6.6](v3.6.5...v3.6.6) (2023-05-26)


### Bug Fixes

* Use backtick around types ([#908](#908)) ([858fe54](858fe54))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants