fix(testing): Validate all tables and relations#85
Merged
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom Sep 13, 2022
Merged
fix(testing): Validate all tables and relations#85kodiakhq[bot] merged 5 commits intocloudquery:mainfrom
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom
Conversation
f75eef8 to
9c5ccd9
Compare
9c5ccd9 to
628c5a9
Compare
yevgenypats
suggested changes
Sep 11, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Good catch! Can we change it to instead of exact number of resources to just at least one resource in every table. as otherwise you can have more resources in one but no resources in others.
bd76271 to
215ed4a
Compare
215ed4a to
253c134
Compare
Member
Author
Good point, done in 253c134 |
hermanschaaf
approved these changes
Sep 12, 2022
yevgenypats
approved these changes
Sep 13, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
🤖 I have created a release *beep* *boop* --- ## [0.5.1](v0.5.0...v0.5.1) (2022-09-13) ### Bug Fixes * **testing:** Validate all tables and relations ([#85](#85)) ([d979863](d979863)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
6 tasks
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 15, 2022
#### Summary The tests on GCP started failing and I believe cloudquery/plugin-sdk#85 is the reason. This should fix it ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I was expecting my Azure mock tests that have relations to fail as I don't handle mocking the related APIs.
I was surprised to see them pass 🙃
The reason is that we need to validate that we got the related resources too.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)