fix(test-migrate): Add CqId to migrate tests tables#695
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Feb 20, 2023
Merged
fix(test-migrate): Add CqId to migrate tests tables#695kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
⏱️ Benchmark results
|
5 tasks
yevgenypats
approved these changes
Feb 20, 2023
kodiakhq Bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
🤖 I have created a release *beep* *boop* --- ## [1.38.2](v1.38.1...v1.38.2) (2023-02-20) ### Bug Fixes * **test-migrate:** Add CqId to migrate tests tables ([#695](#695)) ([e996a11](e996a11)) * **test-migrate:** Ignore order when comparing resources read ([#696](#696)) ([aea1b82](aea1b82)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #694.
Some destinations need at least one not null column (for example a sorting key in ClickHouse). This PRs adds the CqId column for tables created during migrate tests.
I think this is also closer to reality as we always have that column in our schema.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)