feat(destinations): Add migrate_mode#604
Conversation
⏱️ Benchmark resultsComparing with 37254f3
|
| Path string `json:"path,omitempty"` | ||
| Registry Registry `json:"registry,omitempty"` | ||
| WriteMode WriteMode `json:"write_mode,omitempty"` | ||
| MigrateMode MigrateMode `json:"migrate_mode,omitempty"` |
There was a problem hiding this comment.
This can also be a boolean, just found it easier to communicate the purpose using strings
hermanschaaf
left a comment
There was a problem hiding this comment.
This LGTM; are we also planning on supporting a --migrate forced (or similar) flag for the CLI? Might make it a bit easier for users doing things interactively
|
We're also not using the setting anywhere yet - is that because it needs to be implemented in each destination? I think we'll need to pass the mode in to the |
So a CLI will we have to "take" for all specs, where a spec config only "takes" on the specific spec. We can consider adding it but I don't think we can similar flags (that override spec configuration(s)) |
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good. One nit:
Can we move migrate enum code to migrate.go as looks like our enums are growing and maybe also add a small sanity test for marshal/unmarsahl.
6ccda38 to
1ff6062
Compare
Sure, good point. Let me know if 1ff6062 is what you had in mind |
🤖 I have created a release *beep* *boop* --- ## [1.26.0](v1.25.1...v1.26.0) (2023-01-16) ### Features * **destinations:** Add `migrate_mode` ([#604](#604)) ([78b9acb](78b9acb)) ### Bug Fixes * **destination:** Pass proper spec to client constructor ([#606](#606)) ([8370882](8370882)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
#### Summary To be merged after #6759, and needs cloudquery/plugin-sdk#604 <!--
Summary
Related to cloudquery/cloudquery#6600, needed for cloudquery/cloudquery#6763
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)