fix: Send resource validation errors to Sentry#601
Merged
kodiakhq[bot] merged 4 commits intomainfrom Jan 11, 2023
Merged
Conversation
⏱️ Benchmark results
|
erezrokah
approved these changes
Jan 11, 2023
yevgenypats
approved these changes
Jan 11, 2023
| if err := resolvedResource.Validate(); err != nil { | ||
| tableMetrics := p.metrics.TableClient[table.Name][client.ID()] | ||
| p.logger.Error().Err(err).Str("table", table.Name).Str("client", client.ID()).Msg("resource resolver finished with validation error") | ||
| if _, found := sentValidationErrors.LoadOrStore(table.Name, struct{}{}); !found { |
Contributor
There was a problem hiding this comment.
do we we want only to send once per table? I guess it makes sense even though we can miss some things but yeah let's start with that.
Contributor
Author
There was a problem hiding this comment.
Yeah, we may miss some things, but I hope not. And we'll catch it once the first issue is fixed anyway. I figure it's better than using our entire Sentry quota in one sync (unless I'm misunderstanding how Sentry billing works)
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
🤖 I have created a release *beep* *boop* --- ## [1.25.0](v1.24.2...v1.25.0) (2023-01-11) ### Features * **docs:** Sort tables ([#599](#599)) ([8a3bfad](8a3bfad)) * **transformers:** Add support for `net.IP` ([#595](#595)) ([a420645](a420645)) * **transformers:** Add WithPrimaryKeys option ([#598](#598)) ([107006c](107006c)) ### Bug Fixes * Send resource validation errors to Sentry ([#601](#601)) ([5916516](5916516)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource validation errors, like a row missing a PK value, are non-recoverable and need to be fixed by the plugin author. As such, we should know about them when they happen, even though they do not cause a panic in the code. I tried to minimize the number of duplicate messages we send in this case by using a
sync.Map