feat(transformers): Add WithPrimaryKeys option#598
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jan 11, 2023
Merged
feat(transformers): Add WithPrimaryKeys option#598kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
⏱️ Benchmark resultsComparing with 506d4cc
|
yevgenypats
approved these changes
Jan 11, 2023
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Nice. cc @disq (I know you were also waiting for this) :)
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
🤖 I have created a release *beep* *boop* --- ## [1.25.0](v1.24.2...v1.25.0) (2023-01-11) ### Features * **docs:** Sort tables ([#599](#599)) ([8a3bfad](8a3bfad)) * **transformers:** Add support for `net.IP` ([#595](#595)) ([a420645](a420645)) * **transformers:** Add WithPrimaryKeys option ([#598](#598)) ([107006c](107006c)) ### Bug Fixes * Send resource validation errors to Sentry ([#601](#601)) ([5916516](5916516)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
WithPrimaryKeysso we don't need to define extra columns just for the sake of primary keys.The issue with extra columns is that you need to manually configure the column name resolver and type. It's easy to miss those especially when plugins have custom logic for resolvers and types, for example:
https://github.com/cloudquery/cloudquery/blob/cb9b4f85ccb82f850e6ded6c19a39d06c4f2c94a/plugins/source/gcp/client/transformers.go#L17
https://github.com/cloudquery/cloudquery/blob/cb9b4f85ccb82f850e6ded6c19a39d06c4f2c94a/plugins/source/gcp/client/transformers.go#L39
https://github.com/cloudquery/cloudquery/blob/cb9b4f85ccb82f850e6ded6c19a39d06c4f2c94a/plugins/source/gcp/client/transformers.go#L54
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)