fix(destinations): Log correct size of batch#588
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jan 9, 2023
Merged
fix(destinations): Log correct size of batch#588kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
disq
approved these changes
Jan 9, 2023
⏱️ Benchmark resultsComparing with 3b07885
|
hermanschaaf
approved these changes
Jan 9, 2023
yevgenypats
approved these changes
Jan 9, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
🤖 I have created a release *beep* *boop* --- ## [1.24.0](v1.23.0...v1.24.0) (2023-01-09) ### Features * Add local backend for storing cursor state ([#569](#569)) ([3b07885](3b07885)) * Remove codegen ([#589](#589)) ([1c5943a](1c5943a)) ### Bug Fixes * **destinations:** Log correct size of batch ([#588](#588)) ([9cebafe](9cebafe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If we exceed
BatchSizeBytesthe batch size can be lower than the one in the specUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)