feat: Add batch size bytes as additional option#582
Merged
kodiakhq[bot] merged 5 commits intomainfrom Jan 9, 2023
Merged
Conversation
⏱️ Benchmark results
|
disq
reviewed
Jan 6, 2023
| } | ||
| return | ||
| } | ||
| if len(resources) == p.spec.BatchSize || sizeBytes+r.Size() > p.spec.BatchSizeBytes { |
Member
There was a problem hiding this comment.
Using zero as the default value shortcut breaks my heart every time. Maybe allow negative values (erm, -1) to mean "unlimited"?
Contributor
Author
There was a problem hiding this comment.
Sorry, not sure I understood the comment... Was it meant to be a comment on this line? If the batch size limit is 0, the SetDefaults call will ensure it's updated to the default batch size. So there will always be some limit, but you can of course set it to 1PB if you don't want it to affect anything in practice
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
🤖 I have created a release *beep* *boop* --- ## [1.23.0](v1.22.0...v1.23.0) (2023-01-09) ### Features * Add batch size bytes as additional option ([#582](#582)) ([bdd76e0](bdd76e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jan 9, 2023
- Depends on cloudquery/plugin-sdk#582 - Closes #6114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
batchSizeBytesas an additional option to limit batches not only by number of records, but also by number of bytes.