fix(testing): Fix bug in testing missed due to reference to resource being re-used in memdb#567
Merged
kodiakhq[bot] merged 4 commits intomainfrom Jan 3, 2023
Merged
Conversation
hermanschaaf
commented
Jan 3, 2023
| // sort by sync time, then UUID | ||
| if resources[i].Data[syncTimeIndex].String() != resources[j].Data[syncTimeIndex].String() { | ||
| return resources[i].Data[syncTimeIndex].String() < resources[j].Data[syncTimeIndex].String() | ||
| if !resources[i].Data[syncTimeIndex].Equal(resources[j].Data[syncTimeIndex]) { |
Contributor
Author
There was a problem hiding this comment.
Also decided to do better comparison on timestamps here
⏱️ Benchmark resultsComparing with a0d4671
|
erezrokah
approved these changes
Jan 3, 2023
yevgenypats
approved these changes
Jan 3, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
🤖 I have created a release *beep* *boop* --- ## [1.17.2](v1.17.1...v1.17.2) (2023-01-03) ### Bug Fixes * **testing:** Fix bug in testing missed due to reference to resource being re-used in memdb ([#567](#567)) ([95ab353](95ab353)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.