fix(destinations): Set done even if no resources to flush#537
Merged
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom Dec 28, 2022
Merged
Conversation
hermanschaaf
approved these changes
Dec 28, 2022
⏱️ Benchmark resultsComparing with 5ffad03
|
disq
approved these changes
Dec 28, 2022
yevgenypats
approved these changes
Dec 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to cloudquery/cloudquery#6070. This fixes a deadlock in the managed writer when we wait for the flush to finish indefinitely.
The cause is that the resources can already be flushed by another case in the switch, so there might not be resources to flush when we hit the flush case.
The fix is to always pass
doneto the channelUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)