Merged
Conversation
4b560ea to
3677d27
Compare
erezrokah
approved these changes
Sep 4, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good pending some code clean up
| return fmt.Errorf("object is nil %s", reflectType.Elem().String()) | ||
| } | ||
| f := &faker{ | ||
| max_depth: 12, |
Member
There was a problem hiding this comment.
Suggested change
| max_depth: 12, | |
| max_depth: 2, |
I think that should be sufficient for our use cases WDYT?
Contributor
Author
There was a problem hiding this comment.
For me no, usually around 6,7 as I fake the whole response struct and it's quite nested
|
|
||
| func TestSourcePluginSync(t *testing.T, plugin *SourcePlugin, spec specs.Source) { | ||
| t.Parallel() | ||
| // t.Parallel() |
Member
There was a problem hiding this comment.
Suggested change
| // t.Parallel() | |
| // t.Parallel() |
faker/faker.go
Outdated
Comment on lines
+181
to
+210
| // func FakeStruct(obj interface{}) error { | ||
| // e := reflect.ValueOf(obj) | ||
| // if e.Kind() == reflect.Pointer { | ||
| // e = e.Elem() | ||
| // } | ||
| // if e.Kind() != reflect.Struct { | ||
| // return fmt.Errorf("expected struct, got %s", e.Kind()) | ||
| // } | ||
|
|
||
| // for i := 0; i < e.NumField(); i++ { | ||
| // field := e.Type().Field(i) | ||
| // if len(field.Name) == 0 { | ||
| // continue | ||
| // } | ||
| // if unicode.IsLower(rune(field.Name[0])) { | ||
| // continue | ||
| // } | ||
|
|
||
| // // field. | ||
|
|
||
| // columnType, err := valueToSchemaType(field.Type) | ||
| // if err != nil { | ||
| // fmt.Printf("skipping field %s, got err: %v\n", field.Name, err) | ||
| // continue | ||
| // } | ||
|
|
||
| // } | ||
|
|
||
| // return nil | ||
| // } |
Member
There was a problem hiding this comment.
Suggested change
| // func FakeStruct(obj interface{}) error { | |
| // e := reflect.ValueOf(obj) | |
| // if e.Kind() == reflect.Pointer { | |
| // e = e.Elem() | |
| // } | |
| // if e.Kind() != reflect.Struct { | |
| // return fmt.Errorf("expected struct, got %s", e.Kind()) | |
| // } | |
| // for i := 0; i < e.NumField(); i++ { | |
| // field := e.Type().Field(i) | |
| // if len(field.Name) == 0 { | |
| // continue | |
| // } | |
| // if unicode.IsLower(rune(field.Name[0])) { | |
| // continue | |
| // } | |
| // // field. | |
| // columnType, err := valueToSchemaType(field.Type) | |
| // if err != nil { | |
| // fmt.Printf("skipping field %s, got err: %v\n", field.Name, err) | |
| // continue | |
| // } | |
| // } | |
| // return nil | |
| // } |
https://github.com/bxcodec/faker had a lot of issues including inherent race conditions and features we didn't need. This introduces custom faker which will make our life easier in mock tests.
3677d27 to
4850fb2
Compare
Contributor
Author
Thanks! I'll give it some more testing and I think it will be good to merge |
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
🤖 I have created a release *beep* *boop* --- ## [0.1.1](v0.1.0...v0.1.1) (2022-09-06) ### Features * Add custom faker ([#52](#52)) ([34bef4b](34bef4b)) * Add sentry for serve.Serve function ([#54](#54)) ([c1b508f](c1b508f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/bxcodec/faker had a lot of issues
including inherent race conditions and features we didn't need.
This introduces custom faker which will make our life easier
in mock tests.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)